[solved] Rate refund, posible bug?

tapule · December 16, 2015, 6:30pm

Hi,

I’m trying to make a refund under some circumstances and I found “rate_refund” and “simplerate_hook_rate_refund” that seems to be what I need.
The problem is that “simplerate_hook_rate_refund” seems that doesn’t work.

I tried to find the problem and I think that it is in the call to “$db_row = dba_fetch_row($db_result)”

First I get the query and executed directly from my db:
SELECT p_dst,p_msg,uid FROM playsms_tblSMSOutgoing WHERE p_status='2' AND smslog_id='1619'

This give me a row:
p_dst p_msg uid
XXXX Test07 13

Then I looked into “$db_result” with “print_r($db_result, true)”:
DB_result Object ( [autofree] => [dbh] => DB_mysql Object ( [phptype] => mysql [dbsyntax] => mysql [features] => Array ( [limit] => alter [new_link] => 4.2.0 [numrows] => 1 [pconnect] => 1 [prepare] => [ssl] => [transactions] => 1 ) [errorcode_map] => Array ( [1004] => -15 [1005] => -15 [1006] => -15 [1007] => -5 [1008] => -17 [1022] => -5 [1044] => -26 [1046] => -14 [1048] => -3 [1049] => -27 [1050] => -5 [1051] => -18 [1054] => -19 [1061] => -5

I assume that “[numrows] => 1” is the correct thing.
But when “$db_row = dba_fetch_row($db_result)” is executed, nothing is returned.

Also, I see that in this function, it read $p_footer and $unicode, but this fields are not readed from the db

Any hint on that?

anton · December 17, 2015, 2:37am

I don’t understand your post, yet, sorry

how was it “doesn’t work”, how do you use rate_refund, how do you know it doesn’t work ?

I rarely use dba_fetch_row, why use that ? I use dba_fetch_array alot, how do you use the dba_fetch_row

can you show me your code ?

anton

tapule · December 17, 2015, 8:09am

Hi Anton,

The code is the function “simplerate_hook_rate_refund”.

Following the example in my previous post, I only call to “rate_refund” with the “smslog_id”:
$smslog_id = 1619;
rate_refund($smslog_id);

I only added to “simplerate_hook_rate_refund” a pair of lines with “print_r($db_result, true)” to see what is happening:

function simplerate_hook_rate_refund($smslog_id) {
    global $core_config;

    logger_print("start smslog_id:" . $smslog_id, 2, "simplerate refund");
    $db_query = "SELECT p_dst,p_msg,uid FROM " . _DB_PREF_ . "_tblSMSOutgoing WHERE p_status='2' AND smslog_id='$smslog_id'";
    $db_result = dba_query($db_query);
    logger_print("result: ".print_r($db_result, true), 2, "simplerate refund");
    if ($db_row = dba_fetch_row($db_result)) {
        // This is never reached!!
        logger_print("row: ".print_r($db_row, true), 2, "simplerate refund");
        $p_dst = $db_row['p_dst'];
        $p_msg = $db_row['p_msg'];
        $p_footer = $db_row['p_footer']; // This is not needed
        $uid = $db_row['uid'];
        $unicode = $db_row['unicode']; // This is not needed
        if ($p_dst && $p_msg && $uid) {
            if (billing_rollback($smslog_id)) {
                $bill = billing_getdata($smslog_id);
                $credit = $bill['credit'];
                $charge = $bill['charge'];
                $status = $bill['status'];
                ........

anton · December 17, 2015, 10:22am

ok, first, see this:

github.com

antonraharja/playSMS/blob/master/web/plugin/feature/simplerate/fn.php#L256


<?php


/**
* This file is part of playSMS.
*
* playSMS is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* playSMS is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with playSMS. If not, see <http://www.gnu.org/licenses/>.
*/
defined('_SECURE_') or die('Forbidden');


function simplerate_getdst($id) {
	if ($id) {
		$db_query = "SELECT dst FROM " . _DB_PREF_ . "_featureSimplerate WHERE id='$id'";
		$db_result = dba_query($db_query);
		$db_row = dba_fetch_array($db_result);
		$dst = $db_row['dst'];
	}
	return $dst;
}


function simplerate_getprefix($id) {
	if ($id) {
		$db_query = "SELECT prefix FROM " . _DB_PREF_ . "_featureSimplerate WHERE id='$id'";
		$db_result = dba_query($db_query);
		$db_row = dba_fetch_array($db_result);
		$prefix = $db_row['prefix'];
	}
	return $prefix;
}


function simplerate_getbyid($id) {
	if ($id) {
		$db_query = "SELECT rate FROM " . _DB_PREF_ . "_featureSimplerate WHERE id='$id'";
		$db_result = dba_query($db_query);
		$db_row = dba_fetch_array($db_result);
		$rate = $db_row['rate'];
	}
	$rate = (($rate > 0) ? $rate : 0);
	return $rate;
}


function simplerate_getadhoccredit($uid) {
	$balance = 0;


	if ($c_uid = (int) $uid) {
		$db_query = "SELECT adhoc_credit FROM " . _DB_PREF_ . "_tblUser WHERE flag_deleted='0' AND uid='$c_uid'";
		$db_result = dba_query($db_query);
		$db_row = dba_fetch_array($db_result);
		$balance = (float) $db_row['adhoc_credit'];
	}


	return $balance;
}


function simplerate_setadhoccredit($uid, $balance) {
	$balance = (float) $balance;


	if ($c_uid = (int) $uid) {
		$db_query = "UPDATE " . _DB_PREF_ . "_tblUser SET c_timestamp='" . time() . "', adhoc_credit='$balance' WHERE uid='$c_uid' AND flag_deleted='0'";
		dba_query($db_query);
	}
}


// -----------------------------------------------------------------------------------------
function simplerate_hook_rate_getbyprefix($sms_to) {
	global $core_config;
	$found = FALSE;
	$default_rate = ($core_config['main']['default_rate'] > 0 ? $core_config['main']['default_rate'] : 0);
	$rate = $default_rate;
	$prefix = preg_replace('/[^0-9.]*/', '', $sms_to);
	$m = (strlen($prefix) > 10 ? 10 : strlen($prefix));
	for ($i = $m + 1; $i > 0; $i--) {
		$prefix = substr($prefix, 0, $i);
		$db_query = "SELECT id,dst,prefix,rate FROM " . _DB_PREF_ . "_featureSimplerate WHERE prefix='$prefix'";
		$db_result = dba_query($db_query);
		$db_row = dba_fetch_array($db_result);
		if ($db_row['id']) {
			$rate = $db_row['rate'];
			$found = TRUE;
			break;
		}
	}
	if ($found) {
		_log("found rate id:" . $db_row['id'] . " prefix:" . $db_row['prefix'] . " rate:" . $rate . " description:" . $db_row['dst'] . " to:" . $sms_to, 3, "simplerate_hook_rate_getbyprefix");
	} else {
		_log("rate not found to:" . $sms_to . " default_rate:" . $default_rate, 3, "simplerate_hook_rate_getbyprefix");
	}
	$rate = (($rate > 0) ? $rate : 0);
	return $rate;
}


function simplerate_hook_rate_getcharges($uid, $sms_len, $unicode, $sms_to) {
	global $user_config;


	// default length per SMS
	$length = ($unicode ? 70 : 160);


	// connector pdu length
	$minus = ($unicode ? 3 : 7);


	// count unicodes as normal SMS
	$user = user_getdatabyuid($uid);
	if ($unicode && $user['opt']['enable_credit_unicode']) {
		$length = 140;
	}


	// get sms count
	$count = 1;
	if ($sms_len > $length) {
		$count = ceil($sms_len / ($length - $minus));
	}


	// calculate charges
	$rate = rate_getbyprefix($sms_to);
	$charge = $count * $rate;


	_log('uid:' . $uid . ' u:' . $user['username'] . ' len:' . $sms_len . ' unicode:' . $unicode . ' to:' . $sms_to . ' enable_credit_unicode:' . (int) $user['opt']['enable_credit_unicode'] . ' count:' . $count . ' rate:' . $rate . ' charge:' . $charge, 3, 'simplerate_hook_rate_getcharges');


	return array(
		$count,
		$rate,
		$charge
	);
}


function simplerate_hook_rate_cansend($username, $sms_len, $unicode, $sms_to) {
	global $core_config;


	$uid = user_username2uid($username);
	list($count, $rate, $charge) = rate_getcharges($uid, $sms_len, $unicode, $sms_to);


	// sender's
	$adhoc_credit = simplerate_getadhoccredit($uid);
	$adhoc_balance = $adhoc_credit - $charge;
	
	// parent's when sender is a subuser
	if ($parent_uid = user_getparentbyuid($uid)) {
		$adhoc_credit_parent = simplerate_getadhoccredit($parent_uid);
		$adhoc_balance_parent = $adhoc_credit_parent - $charge;
	}


	if ($parent_uid) {
		if (($adhoc_balance_parent >= 0) && ($adhoc_balance >= 0)) {
			
			// update adhoc_credit immediately, parent's too
			simplerate_setadhoccredit($uid, $adhoc_balance);
			simplerate_setadhoccredit($parent_uid, $adhoc_balance_parent);
			
			_log("allowed subuser uid:" . $uid . " parent_uid:" . $parent_uid . " sms_to:" . $sms_to . " adhoc_credit:" . $adhoc_credit . " count:" . $count . " rate:" . $rate . " charge:" . $charge . " adhoc_balance:" . $adhoc_balance . " adhoc_balance_parent:" . $adhoc_balance_parent, 2, "simplerate_hook_rate_cansend");
			
			return TRUE;
		} else {
			_log("disallowed subuser uid:" . $uid . " parent_uid:" . $parent_uid . " sms_to:" . $sms_to . " adhoc_credit:" . $adhoc_credit . " count:" . $count . " rate:" . $rate . " charge:" . $charge . " adhoc_balance:" . $adhoc_balance . " adhoc_balance_parent:" . $adhoc_balance_parent, 2, "simplerate_hook_rate_cansend");
			
			return FALSE;
		}
	} else {
		if ($adhoc_balance >= 0) {


			// update adhoc_credit immediately
			simplerate_setadhoccredit($uid, $adhoc_balance);
			
			_log("allowed user uid:" . $uid . " sms_to:" . $sms_to . " adhoc_credit:" . $adhoc_credit . " count:" . $count . " rate:" . $rate . " charge:" . $charge . " adhoc_balance:" . $adhoc_balance, 2, "simplerate_hook_rate_cansend");
			
			return TRUE;
		} else {
			_log("disallowed user uid:" . $uid . " sms_to:" . $sms_to . " adhoc_credit:" . $adhoc_credit . " count:" . $count . " rate:" . $rate . " charge:" . $charge . " adhoc_balance:" . $adhoc_balance, 2, "simplerate_hook_rate_cansend");
			
			return FALSE;
		}
	}
}


function simplerate_hook_rate_deduct($smslog_id) {
	global $core_config;


	_log("enter smslog_id:" . $smslog_id, 2, "simplerate_hook_rate_deduct");
	$db_query = "SELECT p_dst,p_footer,p_msg,uid,parent_uid,unicode FROM " . _DB_PREF_ . "_tblSMSOutgoing WHERE smslog_id='$smslog_id'";
	$db_result = dba_query($db_query);
	if ($db_row = dba_fetch_array($db_result)) {
		$p_dst = $db_row['p_dst'];
		$p_msg = $db_row['p_msg'];
		$p_footer = $db_row['p_footer'];
		$uid = $db_row['uid'];
		$parent_uid = $db_row['parent_uid'];
		$unicode = $db_row['unicode'];
		if ($p_dst && $p_msg && $uid) {


			// get charge
			$p_msg_len = strlen($p_msg) + strlen($p_footer);
			list($count, $rate, $charge) = rate_getcharges($uid, $p_msg_len, $unicode, $p_dst);


			if (billing_post($smslog_id, $rate, $count, $charge)) {
				_log("deduct successful uid:" . $uid . " parent_uid:" . $parent_uid . " smslog_id:" . $smslog_id, 3, "simplerate_hook_rate_deduct");
				
				return TRUE;
			} else {
				_log("deduct failed uid:" . $uid . " parent_uid:" . $parent_uid . " smslog_id:" . $smslog_id, 3, "simplerate_hook_rate_deduct");


				return FALSE;
			}
		} else {
			_log("rate deduct failed due to empty data uid:" . $uid . " parent_uid:" . $parent_uid . " smslog_id:" . $smslog_id, 3, "simplerate_hook_rate_deduct");
		}
	} else {
		_log("rate deduct failed due to missing data uid:" . $uid . " parent_uid:" . $parent_uid . " smslog_id:" . $smslog_id, 3, "simplerate_hook_rate_deduct");
	}


	return FALSE;
}


function simplerate_hook_rate_refund($smslog_id) {
	global $core_config;


	_log("start smslog_id:" . $smslog_id, 2, "simplerate_hook_rate_refund");
	$db_query = "SELECT p_dst,p_msg,uid FROM " . _DB_PREF_ . "_tblSMSOutgoing WHERE p_status='2' AND smslog_id='$smslog_id'";
	$db_result = dba_query($db_query);
	if ($db_row = dba_fetch_array($db_result)) {
		$p_dst = $db_row['p_dst'];
		$p_msg = $db_row['p_msg'];
		$p_footer = $db_row['p_footer'];
		$uid = $db_row['uid'];
		$unicode = $db_row['unicode'];
		if ($p_dst && $p_msg && $uid) {
			if (billing_rollback($smslog_id)) {
				
				return TRUE;
			}
		}
	}


	return FALSE;
}


function simplerate_hook_setsmsdeliverystatus($smslog_id, $uid, $p_status) {
	//_log("start smslog_id:".$smslog_id, 2, "simplerate_hook_setsmsdeliverystatus");
	if ($p_status == 2) {
		// check in billing table smslog_id with status=0, status=1 is finalized, status=2 is rolled-back
		$db_query = "SELECT id FROM " . _DB_PREF_ . "_tblBilling WHERE status='0' AND smslog_id='$smslog_id'";
		$db_result = dba_query($db_query);
		if ($db_row = dba_fetch_array($db_result)) {
			rate_refund($smslog_id);
		}
	}
}

This file has been truncated. show original

its using dba_fetch_array()

secondly, to successfully refund the message needs to be failed, p_status=2, so you cannot just refund any smslog_id

anton

tapule · December 17, 2015, 10:54am

Hi Anton, thank you for your fast support.

Yes, I know that that the message need to be failed.
I have a message with this condition to test. If you look to the first post, you can see that “dba_query($db_query)” gives me a row, but “dba_fetch_row($db_result)” return nothing.

I executed the same query directly in my mysql db, and it returns the message I tell you:
"SELECT p_dst,p_msg,uid FROM playsms_tblSMSOutgoing WHERE p_status=‘2’ AND smslog_id=‘1619’"
return:
p_dst p_msg uid
XXXX Test07 13

Greetings.

anton · December 17, 2015, 11:50am

ok, sorry for my slowness, so the bug is in the dba_fetch_row() ?

anyway, why forcing to use dba_fetch_row() ? while the code is currently in dba_fetch_array()

I tested dba_fetch_array and row, looks ok on my laptop.

to conclude:

I still don’t know why it never reached that print_r you mentioned, but I also don’t know why you keep using dba_fetch_row while the current code is using dba_fetch_array

and I have tested both dba_fetch_array and dba_fetch_row, both are working as expected, no bugs

anton

tapule · December 17, 2015, 12:03pm

I’m sorry, I mean “dba_fetch_array”, I changed to “dba_fetch_row” to see if this return something, but nothing.
Ok, I will test it again.
Currently I’m on 1.3.1.

This is very strange for me because the data seems to be ok, but “dba_fetch_array” doesn’t returns nothing.

Greetings.

anton · December 17, 2015, 1:01pm

btw, some action is done by playsmsd, so you need to restart it to see it on log

anton

tapule · December 18, 2015, 12:21pm

Finally I solved my problem.
Thank you for your attention Anton.

Greetings.

Topic		Replies	Views
Some messages failed to bill Help	6	1109	November 18, 2015
Database cleaning reversing balance Help	8	1473	January 21, 2023
Billing issue in PlaySMS Help	12	3913	May 25, 2016
Mysql slow query Help	1	346	July 28, 2021
Credit subtracted when sent failed Help	7	483	May 16, 2021

[solved] Rate refund, posible bug?

Related Topics