Credit subtracted when sent failed

Massimiliano_Iavazzo · March 17, 2021, 1:17am

Any solution with 1.4.3 ?

I’m using kannel and even if a sent was failed the credit always comes subtracted.

anton · March 17, 2021, 1:32am

When status sent received playsms will deduct credit. When later received another dlr with status failed then playsms will refund the deducted credit.

Anton

Massimiliano_Iavazzo · March 17, 2021, 1:36am

If I look into the my sent messages I can see a red square near to the failed sms.

Why the credit was deducted? Probably I have a wrong DLR string?

Massimiliano_Iavazzo · March 17, 2021, 1:39am

Into kannel.conf I have

group = sms-service
keyword = default
omit-empty = true
max-messages = 0
get-url = “http://mydomain/index.php?app=call&cat=gateway&plugin=kannel&access=geturl&t=%t&q=%q&a=%a&Q=%Q&smsc=%i”

Sincerely I don’t understand the get-url parameter. Probably the string is wrong ?

neoscopio · March 17, 2021, 11:16am

Does this happens for all gateways? Some providers charge full or partial amount even when SMS fails. Is it configurable?

anton · March 17, 2021, 11:47am

Looking at the code again, I made a mistake, apparently if the billing have been finalized then the refund will not happen.

Here is the flow:

After receiving DLR, playSMS process it, and the DLR will arrive first in simplebilling_hook_setsmsdeliverystatus:

github.com

playsms/playsms/blob/1.4.3/web/plugin/feature/simplebilling/fn.php#L52-L61


function simplebilling_hook_setsmsdeliverystatus($smslog_id, $uid, $p_status) {
	//_log("checking smslog_id:".$smslog_id, 2, "simplebilling setsmsdeliverystatus");
	if (($p_status == 1) || ($p_status == 3)) {
		$db_query = "SELECT id FROM " . _DB_PREF_ . "_tblBilling WHERE status='0' AND smslog_id='$smslog_id'";
		$db_result = dba_query($db_query);
		if ($db_row = dba_fetch_array($db_result)) {
			billing_finalize($smslog_id);
		}
	}
}

When the DLR status is 1 (sent) or 3 (delivered) then the billing is finalized, meaning no more changes, no refund etc, even when later receiving failed status.

If the received DLR is 2 (failed), then this function called, simplerate_hook_setsmsdeliverystatus:

github.com

playsms/playsms/blob/1.4.3/web/plugin/feature/simplerate/fn.php#L244-L254


function simplerate_hook_setsmsdeliverystatus($smslog_id, $uid, $p_status) {
	//_log("start smslog_id:".$smslog_id, 2, "simplerate_hook_setsmsdeliverystatus");
	if ($p_status == 2) {
		// check in billing table smslog_id with status=0, status=1 is finalized, status=2 is rolled-back
		$db_query = "SELECT id FROM " . _DB_PREF_ . "_tblBilling WHERE status='0' AND smslog_id='$smslog_id'";
		$db_result = dba_query($db_query);
		if ($db_row = dba_fetch_array($db_result)) {
			rate_refund($smslog_id);
		}
	}
}

Only if the billing status have not finalized, meaning not receiving sent/delivered before, then the refund called.

So, yes, by default all failed SMS will be refunded, unless its already finalized (previously set as sent/delivered).

I suppose if you want no-refund at all, then just comment all codes inside simplerate_hook_setsmsdeliverystatus(). Dont forget to restart playSMS daemon after code changes.

anton

neoscopio · March 17, 2021, 11:59am

Actually, that makes more sense to me. If the provider sets “sent” and then afterwards, sends “failed”, it should probably be charged anyways. If it sends “Failed” immediately, there is probably a problem with the gateway (upstream funds, maintenance, etc) and probably should be refunded.

system · May 16, 2021, 11:59am

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
[solved] Playsms 1.4 credit not deducting Help	4	1420	February 20, 2019
Credit doesn’t get deducted for after the SMS are being sent and delivered. the message status is pending even though they are delivered successfully Help	1	254	July 19, 2023
Credit doesn't get deducted for some random SMS Help	1	343	August 26, 2022
[solved] PlaySMS not deducting user credit after SMS successfully delievered Help	16	3479	October 22, 2019
Billing issue in PlaySMS Help	12	3981	May 25, 2016

Credit subtracted when sent failed

Related topics