playSMS 1.4.7 test version

anton · November 21, 2023, 12:28am

Hi,

Would like to invite you to tests this version before released as 1.4.7:

Changes:

Simplify db query for faster page load on Reports
Better search form on Reports
Provides sql file for applying db table indexes
Remove dependency to PEAR/DB, now use PDO for db operations
Compatibility up to PHP 8 (should be up to 8.2)
Fix some bugs and security related

Please examine full change logs:

Or for those who have been following, change logs with previous tag:

I hope this version will not introduce new bug or new vulnerability, when you find one, please visit playSMS security policy page:

Thank you,
anton

Azaman_Suleiman1 · November 21, 2023, 4:41pm

Installed playsms-1.4.7 test version
Ubuntu 22.0.4
PHP 8.2.12
Apache2

Under Manage Accounts, when doing Administrator, User or sub-user search will return MySQL error
FATAL ERROR : Database query execution has failed

anton · November 21, 2023, 11:04pm

Hi,

A fix has been committed and pushed:

Please replace plugin/core/dba/fn.php with this version:

github.com

playsms/playsms/blob/9b7c22d56345edd560d9d9c2b67262f9e25e1f76/web/plugin/core/dba/fn.php

<?php

/**
 * This file is part of playSMS.
 *
 * playSMS is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * playSMS is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with playSMS. If not, see <http://www.gnu.org/licenses/>.
 */
defined('_SECURE_') or die('Forbidden');

This file has been truncated. show original

anton

Azaman_Suleiman1 · November 21, 2023, 11:47pm

Thanks Anton. It FIXED after the patch.

Azaman_Suleiman1 · November 22, 2023, 12:07am

Compose Message can’t enter mobile number of receipient.
Got circling icon at the end of box. When press enter, field is cleared (no number)

anton · November 22, 2023, 2:26am

Hmm that one should be fixed already, but let me double check on my test installation. Or maybe try to use comma , instead of Enter.

If you notice issue on visiting phonebook page, that is also being fixed, by copying from 1.5.0-beta8.

anton

Azaman_Suleiman1 · November 22, 2023, 2:47am

Or maybe try to use comma,instead ofEnter .
Ok that works if use ‘,’ (comma) after key in the phone number

anton · November 22, 2023, 3:01am

Hi,

The compose message bug is fixed, download new file here:

github.com

playsms/playsms/blob/960500fae2564da46f129c71db12fc31faa3486c/web/plugin/feature/phonebook/phonebook.php

<?php

/**
 * This file is part of playSMS.
 *
 * playSMS is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * playSMS is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with playSMS. If not, see <http://www.gnu.org/licenses/>.
 */
defined('_SECURE_') or die('Forbidden');

This file has been truncated. show original

Replace plugin/feature/phonebook/phonebook.php

anton

Azaman_Suleiman1 · November 22, 2023, 3:47am

Entering phone no in compose message need to enter comma after keying in mobile number
Seems the Group Icon and Add a use in phonebook is missing. Only import and export icon available

Screenshot 2023-11-22 at 11.44.28 AM

anton · November 22, 2023, 4:08am

Hi,

Fixes committed and pushed, please check the latest phonebook:

You need to download all phonebook’s php files and use them to replace.

anton

Azaman_Suleiman1 · November 22, 2023, 4:26am

Hi

Phonebook OK
Entering new number in compose message still need use comma. Can’t use ENTER after entering number. (previous version can use Enter and comma for entering new number)

Thanks

anton · November 22, 2023, 4:30am

Hi,

So, its like this:

Suppose I have a phonebook entry: 15550001 and 15550002
When I enter 15 up to 1555 or up to 1550000 all good
But when I enter 15557, it wont find any entries on phonebook, then you cannot select anything, and the only way to force it is by using comma
Enter is for selecting whats available options the results of phonebook lookup

anton

Azaman_Suleiman1 · November 22, 2023, 4:33am

Hi

Ok noted on the explaination BUT I was comparing with previous version 1.4.6 it was working to use ENTER when entering NEW number (not found in the phonebook)

Thanks

anton · November 22, 2023, 4:38am

Understood, I kinda remember this issue, I’ll try to fix it

Please have more tests, especially comparing with 1.4.6, thanks

I want to stop working on 1.4.x series and leave it with relatively minor bugs and some minor inconveniences, but still a working app. I’ll be focusing the dev on 1.5 series, for better themes, reporting pages, faster bulk sending and delivery reports etc, if possible that is and if my time/resources allowed

anton

Azaman_Suleiman1 · November 22, 2023, 4:42am

Hi,

Message Template edits open back based template good Morning NOT the actual template to be edited.

Thanks

anton · November 22, 2023, 4:48am

Fixed:

github.com

playsms/playsms/blob/1.4.x/web/plugin/feature/msgtemplate/msgtemplate.php#L10


      
          <?php
          defined('_SECURE_') or die('Forbidden');
          if(!auth_isvalid()){auth_block();};
          
          $gpid = (int) $_REQUEST['gpid'];
          $pid = (int) $_REQUEST['pid'];
          $tid = (int) $_REQUEST['tid'];
          
          if ($tid = $_REQUEST['tid']) {
          	if (! (dba_valid(_DB_PREF_.'_featureMsgtemplate', 'tid', $tid))) {
          		auth_block();
          	}
          }
          
          switch (_OP_) {
          	case "list":
          		$fm_name = "fm_smstemp";
          		$content = _dialog() . "
          			<h2>"._('Message template')."</h2>
          			<form id=$fm_name name=$fm_name action='index.php?app=main&inc=feature_msgtemplate&op=actions' method=POST>

dba_valid() now returns true or false, not the actual value like it used to

anton

anton · November 22, 2023, 5:49am

Hi,

Now its working like previous, please re-update the phonebook.php

anton

Azaman_Suleiman1 · November 22, 2023, 10:08am

Hi
Thanks. It FIXED the message template issue.

Azaman_Suleiman1 · November 22, 2023, 10:38am

Hi Anton,
Here are some of the issues that I found out

Normal User

Settngs
1. Manage site - returns error 500 page
2. Manage subuser - returns > FATAL ERROR : Database query execution has failed
3. Manage credit - returns > FATAL ERROR : Database query execution has failed
Report
1. My credit transactions returns > FATAL ERROR : Database query execution has failed

Admin User

Settings
1. Manage firewall. returns > FATAL ERROR : Database query execution has failed
2. Manage stoplist returns > FATAL ERROR : Database query execution has failed
3. Manage subuser - returns > FATAL ERROR : Database query execution has failed
Report
1. My credit transactions returns > FATAL ERROR : Database query execution has failed

anton · November 22, 2023, 2:34pm

Hi,

Those, and manage sender id, should be fixed now.

Tagged here:

anton

Topic		Replies	Views
playSMS 1.4.7 released News	0	185	December 27, 2023
playSMS version 1.4.5 has been released News	5	2624	September 18, 2021
playSMS 1.4 has been released News	6	2284	September 16, 2016
playSMS github branches Dev	0	21	August 8, 2024
playSMS 1.4.3 has been released News	4	7087	February 12, 2020

Related Topics